fix: Path parameters are not validated properly when they are encoded #18
+94
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florentchauveau
force-pushed
the
issue-17
branch
from
7a9d2b6 to
216ac0d
Compare
Parameters should be unscaped before being sent for validation. gorillamux returns escaped parameters, but openapi3filter expects unescaped parameters.
florentchauveau
force-pushed
the
issue-17
branch
from
216ac0d to
91d2506
Compare
Contributor
Author
|
Hello @jamietanna, any chance we can get this merged? I just rebased the branch on main. Let me know if I need to change anything. |
return http.StatusMethodNotAllowed when appropriate
florentchauveau
force-pushed
the
issue-17
branch
from
91d2506 to
e592981
Compare
mromaszewicz
pushed a commit
to mromaszewicz/echo-middleware
that referenced
this pull request
Feb 7, 2026
gorillamux uses UseEncodedPath(), so FindRoute() returns path parameters in percent-encoded form. openapi3filter expects decoded values, which causes validation of constraints like maxLength and pattern to fail on encoded input (e.g. %2B is 3 chars but decodes to 1 char). Unescape path parameters after route matching and before passing them to openapi3filter. Fixes oapi-codegen#17 Supersedes oapi-codegen#18 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
mromaszewicz
pushed a commit
to mromaszewicz/echo-middleware
that referenced
this pull request
Feb 7, 2026
gorillamux uses UseEncodedPath(), so FindRoute() returns path parameters in percent-encoded form. openapi3filter expects decoded values, which causes validation of constraints like maxLength and pattern to fail on encoded input (e.g. %2B is 3 chars but decodes to 1 char). Unescape path parameters after route matching and before passing them to openapi3filter. Fixes oapi-codegen#17 Supersedes oapi-codegen#18 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
mromaszewicz
added a commit
that referenced
this pull request
Feb 7, 2026
gorillamux uses UseEncodedPath(), so FindRoute() returns path parameters in percent-encoded form. openapi3filter expects decoded values, which causes validation of constraints like maxLength and pattern to fail on encoded input (e.g. %2B is 3 chars but decodes to 1 char). Unescape path parameters after route matching and before passing them to openapi3filter. Fixes #17 Supersedes #18 Co-authored-by: Florent CHAUVEAU <florentch@pm.me> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Member
|
I've cherry picked your change into a different PR, due to the age of this PR, and also added more thorough testing. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17
Parameters should be unscaped before being sent for validation.
gorillamux returns escaped parameters, but openapi3filter expects unescaped parameters.